Breaking changes introduced in minor versions

[nc-wittj]

Describe the bug

#1835 introduced quite a few breaking changes, and was released as a minor version upgrade in a number of services. For example, WithDecryption was not a pointer in ssm.GetParametersInput v1.27 and lower, but was changed to a pointer in v1.28.

Expected Behavior

No breaking changes in minor version releases.

Current Behavior

Seeing errors when trying to upgrade my dependencies:

cannot use true (untyped bool constant) as *bool value in struct literal

Reproduction Steps

Write code before #1835 was merged that references one of the changed fields, and then try to upgrade to the latest release.

Possible Solution

No response

Additional Information/Context

One of the big selling points of the V2 Go SDK was that there were fewer pointers when they weren't necessary (like booleans). This seems to add a lot of them back. 😞

AWS Go SDK V2 Module Versions Used

diff --git a/go.mod b/go.mod
index 25d7d4d3..9b0dea03 100644
--- a/go.mod
+++ b/go.mod
@@ -21,15 +21,15 @@ require (
-	github.com/aws/aws-lambda-go v1.34.1
-	github.com/aws/aws-sdk-go-v2 v1.17.1
-	github.com/aws/aws-sdk-go-v2/config v1.17.7
-	github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue v1.9.19
-	github.com/aws/aws-sdk-go-v2/feature/dynamodb/expression v1.4.25
-	github.com/aws/aws-sdk-go-v2/service/dynamodb v1.17.1
-	github.com/aws/aws-sdk-go-v2/service/s3 v1.29.1
-	github.com/aws/aws-sdk-go-v2/service/sfn v1.14.1
-	github.com/aws/aws-sdk-go-v2/service/sqs v1.19.10
+	github.com/aws/aws-lambda-go v1.37.0
+	github.com/aws/aws-sdk-go-v2 v1.17.3
+	github.com/aws/aws-sdk-go-v2/config v1.18.10
+	github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue v1.10.10
+	github.com/aws/aws-sdk-go-v2/feature/dynamodb/expression v1.4.36
+	github.com/aws/aws-sdk-go-v2/service/dynamodb v1.18.1
+	github.com/aws/aws-sdk-go-v2/service/s3 v1.30.1
+	github.com/aws/aws-sdk-go-v2/service/sfn v1.17.1
+	github.com/aws/aws-sdk-go-v2/service/sqs v1.20.1
@@ -41,25 +41,25 @@ require (
 )
 
 require (
-	github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.9 // indirect
-	github.com/aws/aws-sdk-go-v2/credentials v1.12.20 // indirect
-	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.12.17 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.25 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.19 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/ini v1.3.24 // indirect
-	github.com/aws/aws-sdk-go-v2/internal/v4a v1.0.16 // indirect
-	github.com/aws/aws-sdk-go-v2/service/dynamodbstreams v1.13.20 // indirect
+	github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10 // indirect
+	github.com/aws/aws-sdk-go-v2/credentials v1.13.10 // indirect
+	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.12.21 // indirect
+	github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.27 // indirect
+	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.21 // indirect
+	github.com/aws/aws-sdk-go-v2/internal/ini v1.3.28 // indirect
+	github.com/aws/aws-sdk-go-v2/internal/v4a v1.0.18 // indirect
+	github.com/aws/aws-sdk-go-v2/service/dynamodbstreams v1.14.1 // indirect
 	github.com/aws/aws-sdk-go-v2/service/eventbridge v1.15.1 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.9.10 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.1.20 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/endpoint-discovery v1.7.17 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.19 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.13.19 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.9.11 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.1.22 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/endpoint-discovery v1.7.21 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.21 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.13.21 // indirect
 	github.com/aws/aws-sdk-go-v2/service/ssm v1.20.0 // indirect
-	github.com/aws/aws-sdk-go-v2/service/sso v1.11.23 // indirect
-	github.com/aws/aws-sdk-go-v2/service/ssooidc v1.13.5 // indirect
-	github.com/aws/aws-sdk-go-v2/service/sts v1.16.19 // indirect
-	github.com/aws/smithy-go v1.13.4 // indirect
+	github.com/aws/aws-sdk-go-v2/service/sso v1.12.0 // indirect
+	github.com/aws/aws-sdk-go-v2/service/ssooidc v1.14.0 // indirect
+	github.com/aws/aws-sdk-go-v2/service/sts v1.18.2 // indirect
+	github.com/aws/smithy-go v1.13.5 // indirect
 	github.com/golang/protobuf v1.5.2 // indirect
 	github.com/jmespath/go-jmespath v0.4.0 // indirect
 	github.com/kr/pretty v0.2.2-0.20201124222238-a883a8422cd2 // indirect

Compiler and Version used

go version go1.19.2 darwin/arm64

Operating System and version

MacOS 12

[RanVaknin]

Hi @nc-wittj ,

Thanks for letting us know! I'll take a look into it immediately.

Thanks,
Ran~

[RanVaknin]

Hi @nc-wittj ,

You are right in the sense that this is a breaking change, however this change was fixing an implementation that was broken in the first place.

This fix was due to a long-standing bug, matching the generated SDK clients with the actual AWS service specifications.
although it may be breaking, now the functionality is working as expected.

We apologize for the inconvenience 🙏

Please let us know if we can assist in any other way.
All the best,
Ran~

[github-actions]

This issue has not received a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.