bugfix(AWS SSO Format): #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow teller to use the new SSO format with minimal changes, mostly just needed to upgrade the aws sdk v2 packages for aws
|
@stvnksslr can you please check the conflicts? |
|
Thanks for taking a look fixed |
|
regression in unit tests / linting is caused by this breaking change introduced in a minor version from aws we either need to pin before the change or rework the test invocation pretty frustrating how they rolled this out. Not sure why i didnt run into it originally. |
|
Ok everything's fixed except the vendor file for the new aws versions @kaplanelad in the past you guys wanted only core contributors to touch that directory. |
|
@stvnksslr from what i see the ci fails on linting. |
|
@kaplanelad linter error was import related should be sorted now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#177
Description
fix for the aws SSO new format, this will allow teller to use the new SSO format with minimal changes, mostly just needed to upgrade the aws sdk v2 packages for aws
Motivation and Context
the aws sdk packages used in teller are quite old and are starting to lose compatibility with aws itself. Likely as a security tool there are a number of package sub dependencies that have now been upgraded.
How Has This Been Tested?
Items of note
there are still a few scattered deprecation warnings in the aws files, will get to these when I have time but I dont think they are needed to be fixed to close out this issue.
Checklist