Fix staticcheck linter warnings (#2044)

.github/ISSUE_TEMPLATE.md

@@ -2,10 +2,8 @@ Please fill out the sections below to help us address your issue.
 
 ### Version of AWS SDK for Go?
 
-
 ### Version of Go (`go version`)?
 
-
 ### What issue did you see?
 
 ### Steps to reproduce

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -26,7 +26,7 @@ body:
       label: Current Behavior
       description: |
         What actually happened?
-        
+
         Please include full errors, uncaught exceptions, stack traces, and relevant logs.
         If service responses are relevant, please include wire logs.
     validations:
@@ -38,7 +38,7 @@ body:
       description: |
         Provide a self-contained, concise snippet of code that can be used to reproduce the issue.
         For more complex issues provide a repo with the smallest sample that reproduces the bug.
-        
+
         Avoid including business logic or unrelated code, it makes diagnosis more difficult.
         The code sample should be an SSCCE. See http://sscce.org/ for details. In short, please provide a code sample that we can copy/paste, run and reproduce.
     validations:
@@ -82,4 +82,4 @@ body:
     attributes:
       label: Operating System and version
     validations:
-      required: true 
+      required: true

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,5 @@
 For changes to files under the `/codegen/aws-models` folder, and manual edits to autogenerated code (e.g. `/service/s3/api.go`) please create an Issue instead of a PR for those type of changes.
 
-If there is an existing bug or feature this PR is answers please reference it here.
+If the PR addresses an existing bug or feature, please reference it here.
 
-To help speed up the process and reduce the time to merge please ensure that `Allow edits and access to secrets by maintainers` is checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.
+To help speed up the process and reduce the time to merge please ensure that `Allow edits by maintainers` is checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.

.github/workflows/closed-issue-message.yml

@@ -11,7 +11,7 @@ jobs:
             # These inputs are both required
             repo-token: "${{ secrets.GITHUB_TOKEN }}"
             message: |
-                     ### ⚠️COMMENT VISIBILITY WARNING⚠️ 
-                     Comments on closed issues are hard for our team to see. 
-                     If you need more assistance, please either tag a team member or open a new issue that references this one. 
+                     ### ⚠️COMMENT VISIBILITY WARNING⚠️
+                     Comments on closed issues are hard for our team to see.
+                     If you need more assistance, please either tag a team member or open a new issue that references this one.
                      If you wish to keep having a conversation with other community members under this issue feel free to do so.

CHANGELOG.md

@@ -8627,7 +8627,7 @@
   * Fixes [issue#1191](https://github.com/aws/aws-sdk-go-v2/issues/1191)
 * Refactored internal endpoints model for accessors
 * Feature: updated to latest models
-* New services 
+* New services
   * `service/location` - v1.0.0
   * `service/lookoutmetrics` - v1.0.0
 ## Core SDK Highlights
@@ -8711,15 +8711,15 @@ of the AWS SDK for Go v2. Version 2 incorporates customer feedback from version
 
 ## Breaking Changes
 * `aws`: Updated Config.Retryer member to be a func that returns aws.Retryer ([#1033](https://github.com/aws/aws-sdk-go-v2/pull/1033))
-    * Updates the SDK's references to Config.Retryer to be a function that returns aws.Retryer value. This ensures that custom retry options specified in the `aws.Config` are scoped to individual client instances. 
+    * Updates the SDK's references to Config.Retryer to be a function that returns aws.Retryer value. This ensures that custom retry options specified in the `aws.Config` are scoped to individual client instances.
     * All API clients created with the config will call the `Config.Retryer` function to get an aws.Retryer.
     * Removes duplicate `Retryer` interface from `retry` package. Single definition is `aws.Retryer` now.
 * `aws/middleware`: Updates `AddAttemptClockSkewMiddleware` to use appropriate `AddRecordResponseTiming` naming ([#1031](https://github.com/aws/aws-sdk-go-v2/pull/1031))
     * Removes `ResponseMetadata` struct type, and adds its members to middleware metadata directly, to improve discoverability.
 * `config`: Updated the `WithRetryer` helper to take a function that returns an aws.Retryer ([#1033](https://github.com/aws/aws-sdk-go-v2/pull/1033))
     * All API clients created with the config will call the `Config.Retryer` function to get an aws.Retryer.
 * `API Clients`: Fix SDK's API client enum constant name generation to have expected casing ([#1020](https://github.com/aws/aws-sdk-go-v2/pull/1020))
-    * This updates of the generated enum const value names in API client's `types` package to have the expected casing. Prior to this, enum names were being generated with lowercase names instead of camel case. 
+    * This updates of the generated enum const value names in API client's `types` package to have the expected casing. Prior to this, enum names were being generated with lowercase names instead of camel case.
 * `API Clients`: Updates SDK's API client request middleware stack values to be scoped to individual operation call ([#1019](https://github.com/aws/aws-sdk-go-v2/pull/1019))
     * The API client request middleware stack values were mistakenly allowed to escape to nested API operation calls. This broke the SDK's presigners.
     * Stack values that should not escape are not scoped to the individual operation call.
@@ -8731,7 +8731,7 @@ of the AWS SDK for Go v2. Version 2 incorporates customer feedback from version
     * Adds a PresignClient to the `sts` API client module. Use PresignGetCallerIdentity to obtain presigned URLs for the create presigned URLs for the GetCallerIdentity operation.
     * Fixes [#1021](https://github.com/aws/aws-sdk-go-v2/issues/1021)
 * `aws/retry`: Add package documentation for retry package ([#1033](https://github.com/aws/aws-sdk-go-v2/pull/1033))
-    * Adds documentation for the retry package 
+    * Adds documentation for the retry package
 
 ## Bug Fixes
 * `Multiple API Clients`: Fix SDK's generated serde for unmodeled operation input/output ([#1050](https://github.com/aws/aws-sdk-go-v2/pull/1050))
@@ -8829,7 +8829,6 @@ feedback and to take advantage of modern Go language features.
     * Add support for reading `s3_use_arn_region` from shared config file ([#991](https://github.com/aws/aws-sdk-go-v2/pull/991))
     * Add Utility for getting RequestID and HostID of response ([#983](https://github.com/aws/aws-sdk-go-v2/pull/983))
 
-
 ## Other changes
 * Updates branch `HEAD` points from `master` to `main`.
     * This should not impact your application, but if you have pull requests or forks of the SDK you may need to update the upstream branch your fork is based off of.
@@ -8860,7 +8859,6 @@ The `config#LoadDefaultConfig` function has been updated to require a `context.C
 
 The v2 SDK corrects its behavior to be inline with the AWS CLI and other AWS SDKs. Refer to https://docs.aws.amazon.com/credref/latest/refdocs/overview.html for more information how to use the shared config and credentials files.
 
-
 # Release 2020-11-30
 
 ## Breaking Change
@@ -9020,7 +9018,6 @@ The `config` module's exported types were trimmed down to add clarity and reduce
 * `credentials` module released at `v0.1.1`
 * `ec2imds` module released at `v0.1.1`
 
-
 # Release 2020-09-28
 ## Announcements
 We’re happy to share the updated clients for the v0.25.0 preview version of the AWS SDK for Go V2.
@@ -9060,7 +9057,6 @@ As a part of the refactoring done to v2 preview SDK some components have not bee
 
 We expect additional breaking changes to the v2 preview SDK in the coming releases. We expect these changes to focus on organizational, naming, and hardening the SDK's design for future feature capabilities after it is released for general availability.
 
-
 #### Relocated Packages
 
 In this release packages within the SDK were relocated, and in some cases those packages were converted to Go modules. The following is a list of packages have were relocated.
@@ -9075,7 +9071,6 @@ The `github.com/aws/aws-sdk-go-v2/credentials` module contains refactored creden
 * `github.com/aws/aws-sdk-go-v2/processcreds` => `github.com/aws/aws-sdk-go-v2/credentials/processcreds`
 * `github.com/aws/aws-sdk-go-v2/stscreds` => `github.com/aws/aws-sdk-go-v2/credentials/stscreds`
 
-
 #### Modularization
 
 New modules were added to the v2 preview SDK to allow the components to be versioned independently from each other. This allows your application to depend on specific versions of an API client module, and take discrete updates from the SDK core and other API client modules as desired.
@@ -9084,7 +9079,6 @@ New modules were added to the v2 preview SDK to allow the components to be versi
 * [github.com/aws/aws-sdk-go-v2/credentials](https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/credentials)
 * Module for each API client, e.g. [github.com/aws/aws-sdk-go-v2/service/s3](https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/s3)
 
-
 #### API Clients
 
 The following is a list of the major changes to the API client modules
@@ -9104,14 +9098,12 @@ result, err := client.Scan(context.TODO(), &dynamodb.ScanInput{
 })
 ```
 
-
 #### Configuration
 
 In addition to the `github.com/aws/aws-sdk-go-v2/aws/external` package being made a module at `github.com/aws/aws-sdk-go-v2/config`, the `LoadDefaultAWSConfig` function was renamed to `LoadDefaultConfig`.
 
 The `github.com/aws/aws-sdk-go-v2/aws/defaults` package has been removed. Its components have been migrated to the `github.com/aws/aws-sdk-go-v2/aws` package, and `github.com/aws/aws-sdk-go-v2/config` module.
 
-
 #### Error Handling
 
 The `github.com/aws/aws-sdk-go-v2/aws/awserr` package was removed as a part of the SDK error handling refactor. The SDK now uses typed errors built around [Go v1.13](https://golang.org/doc/go1.13#error_wrapping)'s [errors.As](https://pkg.go.dev/errors#As) and [errors.Unwrap](https://pkg.go.dev/errors#Unwrap) features. All SDK error types that wrap other errors implement the `Unwrap` method. Generic v2 preview SDK errors created with `fmt.Errorf` use `%w` to wrap the underlying error.
@@ -9154,7 +9146,6 @@ Logging an error value will include information from each wrapped error. For exa
 
 > 2020/10/15 16:03:37 operation error DynamoDB: Scan, https response error StatusCode: 400, RequestID: ABCREQUESTID123, ResourceNotFoundException: Requested resource not found
 
-
 #### Endpoints
 
 The `github.com/aws/aws-sdk-go-v2/aws/endpoints` has been removed from the SDK, along with all exported endpoint definitions and iteration behavior. Each generated API client now includes its own endpoint definition internally to the module.

CODE_OF_CONDUCT.md

@@ -1,4 +1,4 @@
 ## Code of Conduct
-This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). 
-For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact 
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
 [email protected] with any additional questions or comments.

CONTRIBUTING.md

@@ -14,29 +14,28 @@ Jump To:
 * [Feature Requests](#feature-requests)
 * [Code Contributions](#code-contributions)
 
-
 ## How to contribute
 
 *Before you send us a pull request, please be sure that:*
 
-1. You're working from the latest source on the master branch.
-2. You check existing open, and recently closed, pull requests to be sure 
+1. You're working from the latest source on the `main` branch.
+2. You check existing open, and recently closed, pull requests to be sure
    that someone else hasn't already addressed the problem.
-3. You create an issue before working on a contribution that will take a 
+3. You create an issue before working on a contribution that will take a
    significant amount of your time.
 
 *Creating a Pull Request*
 
 1. Fork the repository.
-2. In your fork, make your change in a branch that's based on this repo's master branch.
+2. In your fork, make your change in a branch that's based on this repo's `main` branch.
 3. Commit the change to your fork, using a clear and descriptive commit message.
 4. Create a pull request, answering any questions in the pull request form.
 
-For contributions that will take a significant amount of time, open a new 
-issue to pitch your idea before you get started. Explain the problem and 
-describe the content you want to see added to the documentation. Let us know 
-if you'll write it yourself or if you'd like us to help. We'll discuss your 
-proposal with you and let you know whether we're likely to accept it.   
+For contributions that will take a significant amount of time, open a new
+issue to pitch your idea before you get started. Explain the problem and
+describe the content you want to see added to the documentation. Let us know
+if you'll write it yourself or if you'd like us to help. We'll discuss your
+proposal with you and let you know whether we're likely to accept it.
 
 ## Bug Reports
 
@@ -74,9 +73,9 @@ guidelines prior to filing a bug report.
 
 Open an [issue][issues] with the following:
 
-* A short, descriptive title. Ideally, other community members should be able 
+* A short, descriptive title. Ideally, other community members should be able
    to get a good idea of the feature just from reading the title.
-* A detailed description of the the proposed feature. 
+* A detailed description of the the proposed feature.
     * Why it should be added to the SDK.
     *  If possible, example code to illustrate how it should work.
 * Use Markdown to make the request easier to read;
@@ -97,7 +96,7 @@ Please be aware of the following notes prior to opening a pull request:
 
 3. Wherever possible, pull requests should contain tests as appropriate.
    Bugfixes should contain tests that exercise the corrected behavior (i.e., the
-   test should fail without the bugfix and pass with it), and new features 
+   test should fail without the bugfix and pass with it), and new features
    should be accompanied by tests exercising the feature.
 
 4. Pull requests that contain failing tests will not be merged until the test
@@ -112,7 +111,7 @@ Please be aware of the following notes prior to opening a pull request:
 
 ### Testing
 
-To run the tests locally, running the `make unit` command will `go get` the 
+To run the tests locally, running the `make unit` command will `go get` the
 SDK's testing dependencies, and run vet, link and unit tests for the SDK.
 
 ```
@@ -129,7 +128,7 @@ go test -tags codegen ./private/...
 
 See the `Makefile` for additional testing tags that can be used in testing.
 
-To test on multiple platform the SDK includes several DockerFiles under the 
+To test on multiple platform the SDK includes several DockerFiles under the
 `awstesting/sandbox` folder, and associated make recipes to to execute
 unit testing within environments configured for specific Go versions.
 
@@ -170,9 +169,9 @@ This will result in a patch version change.
 * `SDK Bugs` - For minor changes that resolve an issue. This will result in a
 patch version change.
 
-[issues]: https://github.com/aws/aws-sdk-go/issues
-[pr]: https://github.com/aws/aws-sdk-go/pulls
+[issues]: https://github.com/aws/aws-sdk-go-v2/issues
+[pr]: https://github.com/aws/aws-sdk-go-v2/pulls
 [license]: http://aws.amazon.com/apache2.0/
 [cla]: http://en.wikipedia.org/wiki/Contributor_License_Agreement
-[releasenotes]: https://github.com/aws/aws-sdk-go/releases
+[releasenotes]: https://github.com/aws/aws-sdk-go-v2/releases
 

DESIGN.md

@@ -12,4 +12,4 @@ Past Discussions
 ---
 The issues listed here are for documentation purposes, and is used to capture issues and their associated discussions.
 
-[Code of Conduct]: https://github.com/aws/aws-sdk-go-v2/blob/master/CODE_OF_CONDUCT.md
+[Code of Conduct]: https://github.com/aws/aws-sdk-go-v2/blob/main/CODE_OF_CONDUCT.md

Makefile

@@ -246,7 +246,6 @@ unit-race-modules-%:
 		"go test ${BUILD_TAGS} ${RUN_NONE} ./..." \
 		"go test -timeout=1m ${UNIT_TEST_TAGS} -race -cpu=4 ./..."
 
-
 unit-modules-%:
 	@# unit command that uses the pattern to define the root path that the
 	@# module testing will start from. Strips off the "unit-modules-" and
@@ -408,7 +407,6 @@ bench-modules-%:
 		&& go run . -p $(subst _,/,$(subst bench-modules-,,$@)) ${EACHMODULE_FLAGS} \
 		"go test -timeout=10m -bench . --benchmem ${BUILD_TAGS} ${RUN_NONE} ./..."
 
-
 #####################
 #  Release Process  #
 #####################

NOTICE.txt

@@ -1,3 +1,3 @@
 AWS SDK for Go
-Copyright 2015 Amazon.com, Inc. or its affiliates. All Rights Reserved. 
+Copyright 2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 Copyright 2014-2015 Stripe, Inc.