-
Notifications
You must be signed in to change notification settings - Fork 652
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Endpoint Prefix & Idempotency Token Auto-fill, and Authentication Bug…
…fixes (#1518) * Ensure TopDownIndex is used when iterating service operations * Temporary Model Fix Transforms for Location Service * Fixed Idempotency Token Autofill * Fixed Endpoint Prefix Bug * Add Changelog Annotations
- Loading branch information
Showing
143 changed files
with
4,513 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "id": "b51f6004-654f-4c5e-b479-9d04a5045020", | ||
| "type": "bugfix", | ||
| "description": "Fixed an issue that prevent auto-filling of an API's idempotency parameters when not explictly provided by the caller.", | ||
| "modules": [ | ||
| "service/accessanalyzer", | ||
| "service/amp", | ||
| "service/appmesh", | ||
| "service/braket", | ||
| "service/codeguruprofiler", | ||
| "service/grafana", | ||
| "service/nimble", | ||
| "service/proton", | ||
| "service/snowdevicemanagement", | ||
| "service/wisdom" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "id": "b55ca4d6-6d1d-4102-baf0-cb7c49f3bde3", | ||
| "type": "bugfix", | ||
| "description": "Fixed a bug that prevented the resolution of the correct endpoint for some API operations.", | ||
| "modules": [ | ||
| "service/evidently", | ||
| "service/location" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "id": "ce7b78be-3401-4ab3-9c6d-0f40cd08bd56", | ||
| "type": "bugfix", | ||
| "description": "Fixed an issue that caused some operations to not be signed using sigv4, resulting in authentication failures.", | ||
| "modules": [ | ||
| "service/location" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
...src/main/java/software/amazon/smithy/aws/go/codegen/customization/LocationModelFixes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| * Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.smithy.aws.go.codegen.customization; | ||
|
|
||
| import java.util.List; | ||
| import java.util.logging.Logger; | ||
| import software.amazon.smithy.go.codegen.GoSettings; | ||
| import software.amazon.smithy.go.codegen.integration.GoIntegration; | ||
| import software.amazon.smithy.model.Model; | ||
| import software.amazon.smithy.model.shapes.ShapeId; | ||
| import software.amazon.smithy.model.traits.AuthTrait; | ||
| import software.amazon.smithy.utils.ListUtils; | ||
|
|
||
| public class LocationModelFixes implements GoIntegration { | ||
| private static final Logger LOGGER = Logger.getLogger(LocationModelFixes.class.getName()); | ||
|
|
||
| private static final List<ShapeId> SHAPE_ID_EMPTY_AUTH_TRAIT_REMOVAL = ListUtils.of( | ||
| ShapeId.from("com.amazonaws.location#BatchEvaluateGeofences"), | ||
| ShapeId.from("com.amazonaws.location#DescribeGeofenceCollection"), | ||
| ShapeId.from("com.amazonaws.location#DescribeMap"), | ||
| ShapeId.from("com.amazonaws.location#DescribePlaceIndex"), | ||
| ShapeId.from("com.amazonaws.location#DescribeRouteCalculator"), | ||
| ShapeId.from("com.amazonaws.location#DescribeTracker") | ||
| ); | ||
|
|
||
| @Override | ||
| public Model preprocessModel( | ||
| Model model, | ||
| GoSettings settings | ||
| ) { | ||
| if (SHAPE_ID_EMPTY_AUTH_TRAIT_REMOVAL.size() == 0) { | ||
| return model; | ||
| } | ||
|
|
||
| var builder = model.toBuilder(); | ||
|
|
||
| for (ShapeId shapeId : SHAPE_ID_EMPTY_AUTH_TRAIT_REMOVAL) { | ||
| var optionalShape = model.getShape(shapeId); | ||
|
|
||
| if (optionalShape.isEmpty()) { | ||
| continue; | ||
| } | ||
|
|
||
| var shape = optionalShape.get().asOperationShape().get(); | ||
|
|
||
| var optionalAuthTrait = shape.getTrait(AuthTrait.class); | ||
|
|
||
| if (optionalAuthTrait.isEmpty()) { | ||
| LOGGER.warning(() -> String.format("%s no longer has an AuthTrait", shapeId)); | ||
| continue; | ||
| } | ||
|
|
||
| var authTrait = optionalAuthTrait.get(); | ||
|
|
||
| if (authTrait.getValueSet().size() != 0) { | ||
| LOGGER.warning(() -> String.format("%s has a non-empty AuthTrait list and will not be removed", | ||
| shapeId)); | ||
| continue; | ||
| } | ||
|
|
||
| builder.addShape(shape.toBuilder() | ||
| .removeTrait(AuthTrait.ID) | ||
| .build()); | ||
| } | ||
|
|
||
| return builder.build(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.