Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround race condition in ShutdownAPI and logging and custom mem mngmt #2859

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

SergeyRyabinin
Copy link
Contributor

Issue #, if available:
TEST(AwsMemoryManagementTest, MultiInitParallel) fails once in a blue moon with sanitizer report in case of custom memory management enabled.
It is not an issue in case of basic-use non-violated.
We really need to refactor the InitAPI-ShutdownAPI design...
Description of changes:
Preserve the logger for some time to let all pending logging statements to finish.
This is a workaround not a real fix.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review February 27, 2024 17:40
@SergeyRyabinin SergeyRyabinin merged commit 88963a1 into main Feb 27, 2024
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/loggingRace branch February 27, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants