Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flattened #2478

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix flattened #2478

merged 2 commits into from
May 8, 2023

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented May 8, 2023

Issue #, if available:

issues/2476

Description of changes:

There is a bug in code gen where we were not correctly creating flattened list members. This was limited to only "and" shapes with tags in S3. this fixes codegen to correctly create these shapes to avoid a malfored xml error.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review May 8, 2023 17:37
@sbiscigl sbiscigl merged commit 3ce86aa into main May 8, 2023
@sbiscigl sbiscigl deleted the fix-flattened branch May 8, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants