Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the development guide with the correct minimum Python version #7653

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Adam724
Copy link
Contributor

@Adam724 Adam724 commented Nov 7, 2024

Which issue(s) does this change fix?

Why is this change necessary?

The existing development guide states that aws-sam-cli supports Python 3.7+. However, support for python 3.7 appears to have been removed about a year ago, and make init does not work with version <3.8.0.

How does it address the issue?

This PR updates the development guide to indicate that the minimum supported version of Python is 3.8.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Adam724 Adam724 requested a review from a team as a code owner November 7, 2024 15:03
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 7, 2024
@mndeveci mndeveci removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Nov 14, 2024
@mndeveci mndeveci added this pull request to the merge queue Nov 14, 2024
Merged via the queue into aws:develop with commit 13d2379 Nov 14, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants