Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid crashing on invalid function name #7392

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

#7236

Why is this change necessary?

Avoid SAM CLI hard-crashing when it is unable to invoke a Lambda function due to an invalid function name.

How does it address the issue?

Uses a custom-exception and handle it during function invocation.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner August 21, 2024 20:42
@mildaniel mildaniel added this pull request to the merge queue Aug 21, 2024
Merged via the queue into aws:develop with commit 8aa0022 Aug 21, 2024
57 checks passed
@mildaniel mildaniel deleted the handle-value-error branch August 21, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants