fix: appveyor windows job - python version #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is this change necessary? * With release v0.41.0 - MSIs have version 3.7.6 as their base version. Appveyor testing needs to reflect that. How does it address the issue? * Appveyor test frameworks are now using python 3.7.6. The environment variables are set according to: https://www.appveyor.com/docs/windows-images-software/ What side effects does this change have? * None
sriram-mv
force-pushed
the
windows_python_37
branch
from
12b6e6f
to
5c1f949
Compare
jfuss
reviewed
Feb 6, 2020
appveyor-windows.yml
Outdated
| PYTHON_HOME: "C:\\Python37-x64" | ||
| PYTHON_SCRIPTS: "C:\\Python37-x64\\Scripts" | ||
| PYTHON_EXE: "C:\\Python37-x64\\python.exe" | ||
| PYTHON_VERSION: '3.7.5' |
There was a problem hiding this comment.
I think this is only for linux? Do we need this? Looks unused in the file.
There was a problem hiding this comment.
It still adds visibility when looking at a appveyor test run.
|
Don't we need to update all the windows build projects as well? |
sriram-mv
force-pushed
the
windows_python_37
branch
from
a085de0
to
393ebc4
Compare
- It does not look to be used.
jfuss
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Appveyor testing needs to reflect that.
How does it address the issue?
variables are set according to: https://www.appveyor.com/docs/windows-images-software/
What side effects does this change have?
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.