fix: managed stack #1585
Merged
fix: managed stack #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always catch ClientError and BotoCoreError - on windows, create temporary files with delete=False, otherwise it results in a PermissionDeniedError
sanathkr
reviewed
Nov 23, 2019
samcli/commands/deploy/command.py
Outdated
| import logging | ||
|
|
||
| import click | ||
| from click.types import FuncParamType | ||
|
|
||
| from samcli.lib.utils import file |
There was a problem hiding this comment.
file masks inbuilt keyword. Can you rename it?
sanathkr
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
results in a PermissionDeniedError
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.