Smoke test using several templates from SAR #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
approved these changes
Aug 22, 2019
| if isinstance(intrinsic, list): | ||
| return [self.intrinsic_property_resolver(item) for item in intrinsic] | ||
| if not isinstance(intrinsic, dict) or intrinsic == {}: |
| @@ -720,7 +722,7 @@ def resolve_sub_attribute(intrinsic_item, symbol_resolver): | |||
| ) | |||
| result = resolve_sub_attribute(sanitized_item, self._symbol_resolver) | |||
| sub_str = re.sub( | |||
| pattern=r"\$\{" + sub_item + r"\}", string=sub_str, repl=result | |||
| pattern=r"\$\{" + sub_item + r"\}", string=sub_str, repl=str(result) | |||
There was a problem hiding this comment.
why the str? is the resolved result not a string?
There was a problem hiding this comment.
Because Python expects the replacement to be a string. In some cases customers provide an integer value via say a CFN parameter like az number or something.
|
|
||
| with open(template_file_path, "wb") as fp: | ||
| r = requests.get(template_url, stream=True) | ||
| for chunk in r.iter_content(chunk_size=128): |
There was a problem hiding this comment.
nit: could probably do bigger chunks, since I'm assuming the templates are not megabytes in size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Some of the smoke tests failed due to minor bugs in intrinsic resolution. This PR also fixes those bugs.
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.