Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use explicit memory settings for Java cookie cutters #1340

Merged
merged 3 commits into from
Aug 26, 2019
Merged

fix: Use explicit memory settings for Java cookie cutters #1340

merged 3 commits into from
Aug 26, 2019

Conversation

53ningen
Copy link
Contributor

@53ningen 53ningen commented Aug 14, 2019 •
edited
Loading

Issue #, if available:
#1158

Description of changes:

  • Use explicit memory settings for Java cookie cutters
    • Default MemorySize of 128MB is barely sufficient for JVM Lambdas

Checklist:

  • [-] Write Design Document (Do I need to write a design document?)
  • [-] Write unit tests
  • [-] Write/update functional tests
  • [-] Write/update integration tests
  • make pr passes
  • [-] Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss jfuss added the stage/accepted Accepted and will be fixed label Aug 14, 2019
@sriram-mv sriram-mv merged commit 1e98a14 into aws:develop Aug 26, 2019
@53ningen 53ningen deleted the java-cookie-cutters branch August 27, 2019 04:18
@53ningen 53ningen mentioned this pull request Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuss jfuss jfuss approved these changes

Assignees
No one assigned
Labels
stage/accepted Accepted and will be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@53ningen @jfuss @sriram-mv