(feat) boto3 sam deploy #1323
Closed
(feat) boto3 sam deploy #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
Aug 14, 2019
| change_set_id = response.get("Id") | ||
| changes = generate_stack_changes(client, change_set_id, stack_name) | ||
|
|
||
| if len(changes.get("Add") + changes.get("Modify") + changes.get("Remove")) == 0 and fail_on_empty_changset: |
There was a problem hiding this comment.
We need better control flow than just a continuous if statement checks.
| ) | ||
|
|
||
| except ClientError as e: | ||
| if "AccessDeniedException" in e.response["Error"]["Message"]: |
There was a problem hiding this comment.
Is there no specific exception that we can catch? why are we looking at a specific class of Exception within a string message?
| @@ -35,19 +37,197 @@ | |||
| help="The name of the AWS CloudFormation stack you're deploying to. " | |||
| "If you specify an existing stack, the command updates the stack. " | |||
| "If you specify a new stack, the command creates it.") | |||
| @click.option('--s3-bucket', | |||
There was a problem hiding this comment.
I'm assuming this help text information comes directly from aws cli?
|
Thanks for taking a look at this, breaking the dependency of directly shelling out, will help innovate in this space faster :) |
|
Going to close this in favor of #1455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds support for using boto3 with sam deploy. This allows for better ux, allowing us to describe events locally, and other features down the road.
Design doc: #1324
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.