-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commits since 0.19.0 branch freeze #1315
Conversation
- `sam init -r node -d npm` now yeilds a sam template with `nodejs10.x` as runtime instead of `nodejs`
- re-order runtimes per comment
fix: default to nodejs10.x on init
enum34~=1.1.6; python_version<"3.4" | ||
Flask~=1.0.2 | ||
boto3~=1.9, >=1.9.56 | ||
PyYAML~=3.12 | ||
PyYAML~=5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
And Py2 bites again....
|
This reverts commit ad9a171.
Aww man, people still use Windows? :-) Any appetite for a switch, if windows+2.7 then the old method, otherwise, respect my authoriti (symlinks) :-) |
@bubba-h57 Let me have a conversation with the team. I am totally for the switch (mainly because Py2.7 is being removed in Oct as a support Python version), but want to make sure the team is on the same page first. Will respond back here once I have that conversation. |
@bubba-h57 The "keep old behavior with Windows+2.7 only" is good. Are you willing to update and push a new PR with this? |
Certainly. I'll have something updated by the end of the week. |
This reverts commit 360d90a. This commit originally reverted aws#1140 due to os.symlink not being available on windows in Python2.7 stdlib, details here: aws#1315 (comment). We recently removed Python2.7 support in aws#1416, so this commit is a revert of the revert, with some additional black formating to make `make pr` pass.
We were keeping changes since we froze the develop branch for the 0.19.0 release in this branch. Now that 0.19.0 is out, returning these to the develop branch.