Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits since 0.19.0 branch freeze #1315

Merged
merged 13 commits into from
Aug 7, 2019
Merged

Commits since 0.19.0 branch freeze #1315

merged 13 commits into from
Aug 7, 2019

Conversation

awood45
Copy link
Member

@awood45 awood45 commented Aug 5, 2019

We were keeping changes since we froze the develop branch for the 0.19.0 release in this branch. Now that 0.19.0 is out, returning these to the develop branch.

@awood45 awood45 requested review from sriram-mv and sanathkr August 5, 2019 19:29
enum34~=1.1.6; python_version<"3.4"
Flask~=1.0.2
boto3~=1.9, >=1.9.56
PyYAML~=3.12
PyYAML~=5.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jfuss
Copy link
Contributor

jfuss commented Aug 7, 2019

And Py2 bites again....

os.symlink is not available in python2.7's standard library: https://docs.python.org/2.7/library/os.html#os.symlink. This was added in #1140 to address the symlink issue with layers. To unblock this PR, which has a lot of other goodies, I vote to revert #1140 and then take another pass at it separately.

@jfuss jfuss mentioned this pull request Aug 7, 2019
6 tasks
@awood45 awood45 merged commit 65b6f53 into develop Aug 7, 2019
@awood45 awood45 deleted the candidate/release/20 branch August 7, 2019 16:52
@bubba-h57
Copy link
Contributor

bubba-h57 commented Aug 8, 2019

Aww man, people still use Windows? :-) Any appetite for a switch, if windows+2.7 then the old method, otherwise, respect my authoriti (symlinks) :-)

@jfuss
Copy link
Contributor

jfuss commented Aug 12, 2019

@bubba-h57 Let me have a conversation with the team. I am totally for the switch (mainly because Py2.7 is being removed in Oct as a support Python version), but want to make sure the team is on the same page first. Will respond back here once I have that conversation.

@jfuss
Copy link
Contributor

jfuss commented Aug 12, 2019

@bubba-h57 The "keep old behavior with Windows+2.7 only" is good. Are you willing to update and push a new PR with this?

@bubba-h57
Copy link
Contributor

Certainly. I'll have something updated by the end of the week.

jfuss added a commit to jfuss/aws-sam-cli that referenced this pull request Apr 15, 2020
This reverts commit 360d90a.

This commit originally reverted aws#1140 due to os.symlink not being
available on windows in Python2.7 stdlib, details here: aws#1315 (comment). We recently removed Python2.7 support in aws#1416, so this commit
is a revert of the revert, with some additional black formating to make `make pr`
pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants