Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Gradle project configuration. #1087

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix incorrect Gradle project configuration. #1087

merged 1 commit into from
Mar 27, 2019

Conversation

zhangzhx
Copy link
Contributor

Issue #, if available:

This issue is reported in AWS Toolkit JetBrains, but the root cause is the Gradle template
aws/aws-toolkit-jetbrains#854

Description of changes:

Remove the redundant sourceSets configuration and replace the deprecated methods.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv self-requested a review March 27, 2019 20:03
Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my summary of what I understand from the change. Approving based on this:

  • dependencies are updated to remove annotations like not-null, lombok etc
  • sourceSet path is set wrong which prevents IDEs from inferring the source code location

@sriram-mv sriram-mv merged commit cd113eb into aws:develop Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants