feat(type-safe-api): remove dependency on openapi generator and java for all code/docs generation #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b6d8b38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
martenpayne
reviewed
Oct 22, 2024
…for all code/docs generation Remove the dependency on openapi generator and java for code generation for all Type Safe API projects. BREAKING CHANGE: Remove the HTML2 documentation format. Please use HTML_REDOC for HTML documentation.
cogwirrel
force-pushed
the
feat/no-openapi-gen
branch
from
345f3aa
to
b6d8b38
Compare
martenpayne
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on openapi generator and Java for code generation for all Type Safe API projects.
Note that Java/Maven are still a dependency of Smithy, but are not required when OpenAPI is used as the modelling language.
BREAKING CHANGE: Remove the
HTML2documentation format. Please useHTML_REDOCfor HTML documentation.Fixes #793 - no more bash scripts and juggling of tmp directories and absolute paths means we don't fail for directories with spaces in the name.