feat(type-safe-api): remove wrapper scripts for websocket docs projects #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the wrappers around the asyncapi documentation generators and instead call them directly with `npx`. Remove the wrapper around generating the asyncapi spec and instead add it as a subcommand of the type-safe-api script to make it much faster.
van-vothanh
approved these changes
Oct 17, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e3b3b7e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the wrappers around the asyncapi documentation generators and instead call them directly with
npx.Remove the wrapper around generating the asyncapi spec and instead add it as a subcommand of the type-safe-api script to make it much faster.
NB this removes the test for markdown asyncapi docs generation as it was more there to test the wrapper script rather than the behaviour of the dependency we use to generate the docs.