Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] the version of aws-cdk-lib in peerDependency is locked to a specific version #830

Closed
tmokmss opened this issue Sep 25, 2024 · 0 comments · Fixed by #871
Closed

[BUG] the version of aws-cdk-lib in peerDependency is locked to a specific version #830

tmokmss opened this issue Sep 25, 2024 · 0 comments · Fixed by #871
Labels
bug Something isn't working needs-triage

Comments

@tmokmss
Copy link

tmokmss commented Sep 25, 2024

Describe the bug

@aws/pdk requires aws-cdk-lib of a specific version as its peer dependency, making package manager's version resolution inconvenient in some cases. For example:

  1. npm update only installs aws-cdk-lib of the version pdk requires, not the latest aws-cdk-lib.
  2. If a user sets (in their package.json) a greater version of aws-cdk-lib than pdk requires, npm shows a warning like npm WARN ERESOLVE overriding peer dependency.

PDK should not lock the peer dependency to a specific version. It should accept all the versions greater than or equal to a specifi version (e.g. "^2.147.1") to allow users freely choose their aws-cdk-lib version.

Expected Behavior

  "peerDependencies": {
    "@aws-cdk/aws-cognito-identitypool-alpha": "^2.147.1-alpha.0",
    "aws-cdk-lib": "^2.147.1",
    // ...
  },

Current Behavior

  "peerDependencies": {
    "@aws-cdk/aws-cognito-identitypool-alpha": "2.147.1-alpha.0",
    "aws-cdk-lib": "2.147.1",
    // ...
  },

Reproduction Steps

Open node_modules/@aws/pdk/package.json.

Possible Solution

No response

Additional Information/Context

No response

PDK version used

0.23.49

What languages are you seeing this issue on?

Typescript

Environment details (OS name and version, etc.)

macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant