Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing AWS Icons in Diagrams #679

Closed
chris-bateman opened this issue Jan 15, 2024 · 6 comments
Closed

[BUG] Missing AWS Icons in Diagrams #679

chris-bateman opened this issue Jan 15, 2024 · 6 comments
Labels
bug Something isn't working needs-triage

Comments

@chris-bateman
Copy link

Describe the bug

The Diagrams generated by the CdkGraphDiagramPlugin are missing the AWS icons.

Expected Behavior

AWS icons appear in diagram.

Current Behavior

Icons are missing in diagram.
image
image

Reproduction Steps

const graph = new CdkGraph(app,
  {
    plugins: [
      new cdk_graph_plugin_diagram.CdkGraphDiagramPlugin(
      )
    ],
  }
  )

  app.synth();

graph.report();

Run cdk diff
Diagrams appear in cdk.out dir but are missing images.

Possible Solution

No response

Additional Information/Context

Do these images need to be preloaded into the project?

PDK version used

v0.22.49

What languages are you seeing this issue on?

Typescript

Environment details (OS name and version, etc.)

Windows 11, Node 18.19.0, CDK 2.121.1

@chris-bateman chris-bateman added bug Something isn't working needs-triage labels Jan 15, 2024
@chris-bateman
Copy link
Author

Adding that the images are in Node Modules -
image

@chris-bateman
Copy link
Author

Interesting it works on Ubuntu WSL perfectly. Might clear my setup and just try fresh in Windows to see what happens.

@agdimech
Copy link
Contributor

HI Chris - glad you managed to get it working. Were you trying to run PDK via WSL initially or directly on windows?

@chris-bateman
Copy link
Author

HI Chris - glad you managed to get it working. Were you trying to run PDK via WSL initially or directly on windows?

Directly on Windows first which failed. Then I moved to WSL as a troubleshooting step and it worked instantly.

@agdimech
Copy link
Contributor

OK great. We do not support windows native at the moment and definitely recommend WSL.

I will close this as we are tracking onboarding for windows/WSL in a seperate ticket: #664 . Please feel free to re-open if you feel this was closed in error or your issue is still unresolved.

Also - welcome to PDK land :)

@mteichtahl
Copy link
Contributor

mteichtahl commented Jan 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

No branches or pull requests

3 participants