Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Pseudo Function to get Service URL Domain #6632

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Jan 2, 2025

Description of changes

  • Using cfn pseudo function ${AWS::URLSuffix} for getting URL domain

Keeping some hardcoded for EC2 SP's based on #3157

Tests

  • Manually Deployed the Templates

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jan 2, 2025
@himani2411 himani2411 requested review from a team as code owners January 2, 2025 16:09
@himani2411 himani2411 force-pushed the dev-tests branch 2 times, most recently from 087e3f9 to 746da5e Compare January 2, 2025 16:49
@himani2411 himani2411 merged commit 28330be into aws:develop Jan 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants