-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependencies] Upgrade Python version to 3.12 and removed pinning for setuptools #6465
[Dependencies] Upgrade Python version to 3.12 and removed pinning for setuptools #6465
Conversation
This reverts commit 3e9f933. Signed-off-by: Hanwen <[email protected]>
This reverts commit 9277bda.
This reverts commit 69c1169.
Signed-off-by: Giacomo Marciani <[email protected]>
0ce8d10
to
4a0600a
Compare
@@ -6,6 +6,8 @@ CHANGELOG | |||
|
|||
**CHANGES** | |||
- Pyxis is now disabled by default and it must be manually enabled on the head node. | |||
- Upgrade Python runtime to version 3.12 in ParallelCluster Lambda Layer. | |||
- Remove version pinning for setuptools to version prior to 70.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, we did not document CLI Python dependencies upgrade in ChangeLog. So this line is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth it to document these dependencies because:
- Changing the PC Lambda Layer runtime is equivalent to making pcluster compatible with a newer version of Python. When old Lambda runtimes are used, users may receive warnings; this upgrade may solve these warnings and it's useful to keep track of this improvement.
- setuptools: this package affects the pcluster installation, so if the user faces issues in installing pcluster it may also be because of changes in the new version of setuptools.
Description of changes
Tests
Tested in the original PR.
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.