Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Upgrade Python version to 3.12 and removed pinning for setuptools #6465

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Oct 14, 2024

Description of changes

Tests

Tested in the original PR.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani changed the title Wip/mgiacomo/3.11.1/cherry pick upgrades from develop 1014 1 [Dependencies] Upgrade Python version to 3.12, NodeJs to version 18 in Pc Lambda Layer and removed pinning for setuptools Oct 14, 2024
@gmarciani gmarciani added dependencies Pull requests that update a dependency file and removed Security labels Oct 14, 2024
@gmarciani gmarciani changed the title [Dependencies] Upgrade Python version to 3.12, NodeJs to version 18 in Pc Lambda Layer and removed pinning for setuptools [Dependencies] Upgrade Python version to 3.12 and removed pinning for setuptools Oct 14, 2024
@gmarciani gmarciani force-pushed the wip/mgiacomo/3.11.1/cherry-pick-upgrades-from-develop-1014-1 branch from 0ce8d10 to 4a0600a Compare October 14, 2024 12:57
@@ -6,6 +6,8 @@ CHANGELOG

**CHANGES**
- Pyxis is now disabled by default and it must be manually enabled on the head node.
- Upgrade Python runtime to version 3.12 in ParallelCluster Lambda Layer.
- Remove version pinning for setuptools to version prior to 70.0.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, we did not document CLI Python dependencies upgrade in ChangeLog. So this line is optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth it to document these dependencies because:

  1. Changing the PC Lambda Layer runtime is equivalent to making pcluster compatible with a newer version of Python. When old Lambda runtimes are used, users may receive warnings; this upgrade may solve these warnings and it's useful to keep track of this improvement.
  2. setuptools: this package affects the pcluster installation, so if the user faces issues in installing pcluster it may also be because of changes in the new version of setuptools.

@hanwen-pcluste hanwen-pcluste marked this pull request as ready for review October 14, 2024 13:21
@hanwen-pcluste hanwen-pcluste requested review from a team as code owners October 14, 2024 13:21
@gmarciani gmarciani merged commit 232681c into aws:release-3.11 Oct 14, 2024
29 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3.11.1/cherry-pick-upgrades-from-develop-1014-1 branch October 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants