Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools version to be less than 70.0.0 #6251

Merged
merged 1 commit into from
May 22, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

The setuptools 70.0.0 release broke unit tests with Python 3.12. For example: https://github.com/aws/aws-parallelcluster/actions/runs/9196405216/job/25294425565?pr=6250)

The same failure has been encountered by others. For example, vllm-project/vllm#4961

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hanwen-pcluste hanwen-pcluste requested review from a team as code owners May 22, 2024 18:42
@hanwen-pcluste hanwen-pcluste added the skip-changelog-update Disables the check that enforces changelog updates in PRs label May 22, 2024
@hanwen-pcluste hanwen-pcluste force-pushed the developfix branch 2 times, most recently from 625c238 to 06a2a2b Compare May 22, 2024 19:19
The [setuptools 70.0.0](https://pypi.org/project/setuptools/#history) release broke unit tests with Python 3.12. For example: https://github.com/aws/aws-parallelcluster/actions/runs/9196405216/job/25294425565?pr=6250)

The same failure has been encountered by others. For example, vllm-project/vllm#4961

Signed-off-by: Hanwen <[email protected]>
@hanwen-pcluste hanwen-pcluste merged commit 69c1169 into aws:develop May 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants