Add validator to fail when a user is not using a custom ami and is using an instance_type that is not supported by openRM #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s using an instance_type that is not supported by openRM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6006 +/- ##
========================================
Coverage 90.18% 90.18%
========================================
Files 180 180
Lines 15776 15784 +8
========================================
+ Hits 14227 14235 +8
Misses 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
reviewed
Jan 12, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hgreebe
force-pushed
the
develop
branch
2 times, most recently
from
79ff565 to
d65ff9c
Compare
enrico-usai
reviewed
Jan 12, 2024
hgreebe
force-pushed
the
develop
branch
2 times, most recently
from
388d363 to
135e9b5
Compare
…port instance types
enrico-usai
reviewed
Jan 13, 2024
enrico-usai
previously approved these changes
Jan 16, 2024
| ): | ||
| self._add_failure( | ||
| f"The instance type '{instance_type}' is not supported by NVIDIA OpenRM drivers. " | ||
| f"OpenRM can only be used on any Turing or later GPU architectures. " |
There was a problem hiding this comment.
minor: you can remove the f from the lines where there are no variables to replace.
enrico-usai
approved these changes
Jan 16, 2024
enrico-usai
pushed a commit
to enrico-usai/aws-parallelcluster
that referenced
this pull request
Jan 16, 2024
…ing an instance_type that is not supported by openRM (aws#6006) * Add validator to fail when a customer is not using a custom ami and is using an instance_type that is not supported by openRM * Update changelog to reflect which instances are not supported with the OpenRM Drivers * Add a constant for supported NVIDIA OpenRM Architecture and the unsupport instance types * Improve CHANGELOG Signed-off-by: Enrico Usai <[email protected]>
lukeseawalker
pushed a commit
to lukeseawalker/aws-parallelcluster
that referenced
this pull request
Jan 17, 2024
…ing an instance_type that is not supported by openRM (aws#6006) * Add validator to fail when a customer is not using a custom ami and is using an instance_type that is not supported by openRM * Update changelog to reflect which instances are not supported with the OpenRM Drivers * Add a constant for supported NVIDIA OpenRM Architecture and the unsupport instance types * Improve CHANGELOG
enrico-usai
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ing an instance_type that is not supported by openRM (#6006) * Add validator to fail when a customer is not using a custom ami and is using an instance_type that is not supported by openRM * Update changelog to reflect which instances are not supported with the OpenRM Drivers * Add a constant for supported NVIDIA OpenRM Architecture and the unsupport instance types * Improve CHANGELOG Signed-off-by: Enrico Usai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.