Change shellcheck severity level to warning #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judysng
added
the
skip-changelog-update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5996 +/- ##
========================================
Coverage 90.18% 90.18%
========================================
Files 180 180
Lines 15780 15780
========================================
Hits 14231 14231
Misses 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
reviewed
Jan 8, 2024
api/gradlew
Outdated
| @@ -36,9 +36,9 @@ while [ -h "$PRG" ] ; do | |||
| fi | |||
| done | |||
| SAVED="`pwd`" | |||
| cd "`dirname \"$PRG\"`/" >/dev/null | |||
| cd "`dirname \"$PRG\"`/" >/dev/null || exit | |||
There was a problem hiding this comment.
we can use $() syntax as well
There was a problem hiding this comment.
Updated all the usages of ` in gradlew to use $()
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Signed-off-by: Judy Ng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
tests/folder (many warnings are from the tests)Tests
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.