[release-3.8] Use older versions of jsonschema and urllib3 for Lambda Layer #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.8 #5874 +/- ##
===============================================
+ Coverage 90.03% 90.06% +0.02%
===============================================
Files 180 180
Lines 15652 15654 +2
===============================================
+ Hits 14093 14099 +6
+ Misses 1559 1555 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmarciani
previously approved these changes
Nov 22, 2023
hanwen-pcluste
force-pushed
the
release-3.8
branch
2 times, most recently
from
3c785a8
to
153a05e
Compare
hanwen-pcluste
added
the
skip-changelog-update
Pcluster API execution fails if using the latest version of the packages. * jsonschema introduced breaking changes in 4.18.0 in July 2023. Therefore, we use version 4.17.3. aws/aws-cdk#26300 * urllib released 2.0 in May 2023. Pcluster API has been released with urllib 1.x. Therefore, we use version 1.x. The root cause of both issues are because Lambda Function environment has older boto3/botocore versions than latest released versions on PyPi. Specifically, when we prepare lambda layers, the dependencies are installed according to new boto3/botocore versions. When running the Lambda function, the older boto3/botocore are not compatible with the dependencies we provide in Lambda layers. Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
force-pushed
the
release-3.8
branch
from
153a05e
to
eb87266
Compare
|
Seems like Lambda Function is gradually upgrading their runtime. We may don't have to merge the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use older versions of jsonschema and urllib3 for Lambda Layer
Pcluster API execution fails if using the latest version of the packages.
The root cause of both issues are because Lambda Function environment has older boto3/botocore versions than latest released versions on PyPi.
Specifically, when we prepare lambda layers, the dependencies are installed according to new boto3/botocore versions. When running the Lambda function, the older boto3/botocore are not compatible with the dependencies we provide in Lambda layers.
Signed-off-by: Hanwen [email protected]
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.