-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple custom actions validators #5134
Conversation
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #5134 +/- ##
===========================================
+ Coverage 89.65% 89.72% +0.07%
===========================================
Files 175 175
Lines 15131 15241 +110
===========================================
+ Hits 13565 13675 +110
Misses 1566 1566
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
Signed-off-by: Paolo Sacconier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
@@ -121,26 +125,134 @@ def _ec2_wait(region, instances, waiter_type): | |||
waiter.wait(InstanceIds=instances) | |||
|
|||
|
|||
@pytest.fixture(scope="session", name="resources_dir") | |||
def resources_dir_fixture(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, non-blocking: This method and some of the below ones are copied from another class, we may put them under the generic conftest.py
to DRY
for i in range(10): | ||
if i % 2 == 0: | ||
cache_affinity = i % 2 | ||
url = f"{https_url}&cache_affinity={cache_affinity}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick,non-blocking: you can just hardcode 0 in here
Or, if you want to have just the half of the https url with cache, this does not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, introduced after adding s3 urls, fixed
Signed-off-by: Paolo Sacconier <[email protected]>
Description of changes
Tests
References
Checklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.