Add a backing instance max count config option for clustermgtd to be robust to eventual EC2 consistency #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #613 +/- ##
===========================================
+ Coverage 90.73% 90.78% +0.04%
===========================================
Files 20 20
Lines 3109 3125 +16
===========================================
+ Hits 2821 2837 +16
Misses 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
e8c05c7 to
e169447
Compare
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
e169447 to
757277a
Compare
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
757277a to
1aa7155
Compare
dreambeyondorange
changed the title
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
10 times, most recently
from
ce0bb32 to
70b11f6
Compare
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
3 times, most recently
from
9ed93bf to
1596798
Compare
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
3 times, most recently
from
8b8adb7 to
8fd54d7
Compare
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
8fd54d7 to
de74342
Compare
…e robust to eventual EC2 consistency Adding a config option to clustermgtd, ec2_backing_instance_max_count, to allow more time for describe-instances to reach eventual consistency with run-instances data Passes the max count and map to is_healthy() and is_bootstrap_failure() for static and dynamic nodes to evaluate the count for individual instances.
lukeseawalker
previously approved these changes
Feb 20, 2024
dreambeyondorange
force-pushed
the
backing_instance_timeout
branch
from
de74342 to
1cad1c9
Compare
lukeseawalker
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a backing_instance_max_count config option for clustermgtd to be robust to eventual EC2 consistency
Adding a config option to clustermgtd, ec2_backing_instance_max_count, to allow more time for describe-instances to reach eventual consistency with run-instances data
Passes the max count and map to is_healthy() for static and dynamic nodes to evaluate the count for individual instances.
Tests
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.