[release-3.8] Reorder instance to Slurm node assignation steps #595 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Carrogu <[email protected]> (cherry picked from commit 25cce71)
Add error code and message on ClientError when launching instances, for RunInstances and CreateFleet API calls Signed-off-by: Luca Carrogu <[email protected]> (cherry picked from commit 418fa7b)
Add exp backoff in launch ec2 instances call on throttling. This is specially useful during all-or-nothing scaling, during all-in optimization call, to avoid quiting the all-in call and enter the job loop. The longer retry time requires to increases the orphaned_instance_timeout by 1 min, from 120 to 180 secs Signed-off-by: Luca Carrogu <[email protected]> (cherry picked from commit 322b376)
Reorder instance to Slurm node assignation steps * from scontrol update node / write on dynamoDB / write on Route53 * to write on dynamoDB / write on Route53 /scontrol update node so that the assignation of the instance to Slurm node is done as last step, when all the data needed is set Signed-off-by: Luca Carrogu <[email protected]>
EddyMM
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reorder instance to Slurm node assignation steps
so that the assignation of the instance to Slurm node is done as last step, when all the data needed is set
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.