Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel. #2852

Open
wants to merge 2 commits into
base: release-3.12
Choose a base branch
from

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Dec 11, 2024

DECIDED TO NOT MERGE THIS FOR RELEASE 3.12. AS NOT REQUIRED FOR KERNEL 6.5

Description of changes

On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel.

This is required because, NVIDIA driver must be compiled with the same gcc version used by the kernel.
If this is not the case, the NVIDIA driver installation would fail a compiler version check.
On newer version of Ubuntu22.04 (kernel 6.8+), the kernel is compiled with gcc-12, however gcc-11 is installed as default version by build-essentials, making this change necessary.

  • Pinned Cinc to v23 for the execution of spec tests in the PR. We use Cinc v23 locally. With Cinc v24 the newly introduced unit test fails because the test cannot find the resource for ubuntu22. this does not happen with Cinc v23 and does not happen during cookbook execution (which uses Cinc v18)

Tests

  • Build image Ubuntu 22.04 arm (x86 affected by another issue, will be tested on pipeline)
  • test_efa (which is part of the suite used to validate gpus) succeeded

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani changed the base branch from develop to release-3.12 December 11, 2024 12:42
@gmarciani gmarciani force-pushed the wip/mgiacomo/3120/fix-arm-ubuntu-1211-1 branch 5 times, most recently from dc3f41b to 48f8bc8 Compare December 12, 2024 09:57
@gmarciani gmarciani changed the title Wip/mgiacomo/3120/fix arm ubuntu 1211 1 On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel. Dec 12, 2024
@gmarciani gmarciani force-pushed the wip/mgiacomo/3120/fix-arm-ubuntu-1211-1 branch 4 times, most recently from c4747c4 to 50c493d Compare December 12, 2024 10:40
@gmarciani gmarciani marked this pull request as ready for review December 12, 2024 17:49
@gmarciani gmarciani requested review from a team as code owners December 12, 2024 17:49
@gmarciani gmarciani force-pushed the wip/mgiacomo/3120/fix-arm-ubuntu-1211-1 branch 4 times, most recently from 0b03399 to f438831 Compare December 13, 2024 14:37
… used to compile the kernel.

This is required because, NVIDIA driver must be compiled with the same gcc version used by the kernel.
If this is not the case, the NVIDIA driver installation would fail a compiler version check.
On newer version of Ubuntu22.04 (kernel 6.8+), the kernel is compiled with gcc-12, however gcc-11 is installed as default version by build-essentials, making this change necessary.

Signed-off-by: Giacomo Marciani <[email protected]>
@gmarciani gmarciani force-pushed the wip/mgiacomo/3120/fix-arm-ubuntu-1211-1 branch from f438831 to a0ea069 Compare December 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants