[DRAFT] Configure Enroot and Pyxis only on HeadNode #2816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himani2411
changed the title
himani2411
force-pushed
the
release-3.11.1
branch
from
a8b0b3d to
8998aff
Compare
hgreebe
reviewed
Oct 10, 2024
cookbooks/aws-parallelcluster-platform/templates/pyxis/pyxis.conf.erb
Outdated
Show resolved
Hide resolved
himani2411
force-pushed
the
release-3.11.1
branch
from
8998aff to
c914e55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.11 #2816 +/- ##
===============================================
Coverage ? 76.67%
===============================================
Files ? 22
Lines ? 2242
Branches ? 0
===============================================
Hits ? 1719
Misses ? 523
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
himani2411
force-pushed
the
release-3.11.1
branch
4 times, most recently
from
9a091ef to
e77e02b
Compare
himani2411
force-pushed
the
release-3.11.1
branch
5 times, most recently
from
9321be0 to
6d017a9
Compare
gmarciani
requested changes
Oct 11, 2024
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_common.rb
Outdated
Show resolved
Hide resolved
| directory "#{node['cluster']['shared_dir']}/enroot" do | ||
| owner node['cluster']['cluster_user'] | ||
| # group node['cluster']['cluster_user'] | ||
| mode '1777' |
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_common.rb
Outdated
Show resolved
Hide resolved
gmarciani
requested changes
Oct 11, 2024
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_common.rb
Outdated
Show resolved
Hide resolved
himani2411
force-pushed
the
release-3.11.1
branch
10 times, most recently
from
4f2fc28 to
bbabdf0
Compare
himani2411
force-pushed
the
release-3.11.1
branch
4 times, most recently
from
57e5199 to
2efe619
Compare
* Replacing sed commands with templates * Replacing creation of directories with chef resource * Adding Chef Attributes for enabling Pyxis * Changing Kitchen test for Enroot and Pyxis
himani2411
force-pushed
the
release-3.11.1
branch
from
2efe619 to
3813a87
Compare
hgreebe
reviewed
Oct 14, 2024
| ENROOT_CACHE_PATH ${ENROOT_CACHE_PATH} | ||
| ENROOT_DATA_PATH /tmp/enroot/data/user-$(id -u) | ||
| ENROOT_RUNTIME_PATH /run/enroot/user-$(id -u) | ||
| ENROOT_CONFIG_PATH |
There was a problem hiding this comment.
Maybe we should create an enroot config path. Like /home/user-$(id -u)/.config/enroot
There was a problem hiding this comment.
Our users could share the /home folder and we would end up in the original situation where these paths expected to be local became shared. I suggest to avoid the use of /home for these paths. In Pyxis/Enroot docs/Example sometimes they mention /home because they assume it's a local folder.
|
Closed in favour of #2820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
{"cluster":{"pyxis":{"enabled":true},"enroot":{"enabled":true}}}References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.