[ADC] Set default node package for build image command #2788
Conversation
| if aws_region.start_with?("us-iso") && !node['cluster']['custom_awsbatchcli_package'].empty? | ||
| node.default['cluster']['custom_awsbatchcli_package'] = "#{node['cluster']['artifacts_s3_url']}/dependencies/awsbatch/aws-parallelcluster.tgz" | ||
| end |
There was a problem hiding this comment.
Is only removing the code enough? In the below code, it will try to install from pip and will fail, right
There was a problem hiding this comment.
From what I know we dont even support Batch scheduler in ADC
There was a problem hiding this comment.
it skips the whole install part for aws batch in ADC due to this line: return if aws_region.start_with?("us-iso")
| node.default['cluster']['custom_node_package'] = "#{node['cluster']['artifacts_s3_url']}/dependencies/node/aws-parallelcluster-node.tgz" | ||
| node_package = "aws-parallelcluster-node-#{node['cluster']['parallelcluster-node-version']}.tgz" | ||
|
|
||
| node.default['cluster']['custom_node_package'] = "#{node['cluster']['s3_url']}/parallelcluster/#{node['cluster']['parallelcluster-node-version']}/node/#{node_package}" |
There was a problem hiding this comment.
Are we making changes in the S3 location to upload default Node package in this location. As I dont see node package in s3 for other regions?
There was a problem hiding this comment.
when we release in adc, we will also have to release a node and cookbook package so that they can use those for build image. I think we have a similar path where we have been publish the cookbook in s3 in commercial.
Description of changes
build-imagecommand can be run without having to specify custom packages in ADCBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.