Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildImage] Download build image dependencies from s3 bucket #2761

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Jun 14, 2024

Description of changes

  • Download build image dependencies from s3 bucket
  • Allows support for build image command in environments without internet connection

Tests

  • Did build-image manual tests on all OSes with x86_64 and arm architectures
  • Ran createami integration test

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe hgreebe force-pushed the develop branch 2 times, most recently from cadc93d to 5c8af61 Compare June 14, 2024 13:54
@hgreebe hgreebe marked this pull request as ready for review June 14, 2024 13:57
@hgreebe hgreebe requested review from a team as code owners June 14, 2024 13:57
@hanwen-pcluste
Copy link
Contributor

Are the downloaded tarballs deleted after installation?

@hgreebe hgreebe force-pushed the develop branch 2 times, most recently from 1be56e8 to 6429473 Compare June 14, 2024 18:45
hanwen-pcluste
hanwen-pcluste previously approved these changes Jun 17, 2024
Copy link
Contributor

@hanwen-pcluste hanwen-pcluste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hgreebe hgreebe merged commit a77217b into aws:develop Jun 17, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants