-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BuildImage] Download build image dependencies from s3 bucket #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgreebe
force-pushed
the
develop
branch
2 times, most recently
from
June 14, 2024 13:54
cadc93d
to
5c8af61
Compare
Are the downloaded tarballs deleted after installation? |
cookbooks/aws-parallelcluster-platform/recipes/install/awscli.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/recipes/install/cookbook_virtualenv.rb
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/recipes/install/cookbook_virtualenv.rb
Outdated
Show resolved
Hide resolved
hgreebe
force-pushed
the
develop
branch
2 times, most recently
from
June 14, 2024 18:45
1be56e8
to
6429473
Compare
hgreebe
force-pushed
the
develop
branch
4 times, most recently
from
June 17, 2024 14:28
fce9e50
to
b1feac5
Compare
hanwen-pcluste
previously approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
hanwen-pcluste
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.