Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the CFN_BOOTSTRAP_VIRTUALENV_PATH variable in cfn-hook-update.conf #2758

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

himani2411
Copy link
Contributor

Description of changes

Adding the CFN_BOOTSTRAP_VIRTUALENV_PATH variable in cfn-hook-update.conf

Some of the Updates were failing with WaitCondition timed out. Received 0 conditions when expecting 1 and no logs for that timestamp in chef-client, cfn-init of the HeadNode.

Ref: #2742

Tests

  • ONGOING
{%- import 'common.jinja2' as common with context -%}
---
test-suites:
  create:
    test_create.py::test_create_disable_sudo_access_for_default_user:
      dimensions:
        - regions: [ "ap-northeast-2" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          schedulers: [ "slurm" ]
          oss: [ "rocky8" ]


References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.47%. Comparing base (7d414fe) to head (d753c64).
Report is 120 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2758      +/-   ##
===========================================
- Coverage    76.48%   76.47%   -0.02%     
===========================================
  Files           22       22              
  Lines         2220     2219       -1     
===========================================
- Hits          1698     1697       -1     
  Misses         522      522              
Flag Coverage Δ
unittests 76.47% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 enabled auto-merge (squash) June 12, 2024 22:46
@himani2411 himani2411 merged commit e22ecc0 into aws:develop Jun 12, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants