Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Amazon Linux 2023 #2692

Merged
merged 44 commits into from
Jun 12, 2024
Merged

Support Amazon Linux 2023 #2692

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
d7046e8
[POC] Add support for Amazon Linux 2023
enrico-usai Jun 29, 2023
4787aa1
[AL2023] Add support for Amazon Linux 2023 - ARMPL
Apr 4, 2024
118a1be
[AL2023] Installing NVIDIA driver and kernel-modules-extra which is r…
Apr 5, 2024
d205aca
[AL2023] Installing gdrcopy
Apr 5, 2024
b19b8bb
[AL2023] Installing stunnel
Apr 5, 2024
bad0831
[AL2023] Disable SElinux requires a reboot
Apr 5, 2024
2780d79
[AL2023] ModuleFile path is /etc/environment-modules/modulespath for …
Apr 5, 2024
bb5b9e1
[AL2023] We do not install DCV with Al2023 as its not supported.
Apr 5, 2024
293bac8
[AL2023] Installing only available packages
Apr 5, 2024
9cb52e2
[AL2023] Add support for Amazon Linux 2023 - EFA
Apr 5, 2024
b49713a
[AL2023] Add support for Amazon Linux 2023 - EFS
Apr 5, 2024
ba5038c
[AL2023] Add support for Amazon Linux 2023 - Ephemeral drive
Apr 5, 2024
0092c16
[AL2023]Add support for Amazon Linux 2023 - Lustre Client
Apr 5, 2024
e67ab39
[AL2023] Removing `cfnconfig_mixed` test from environment_install as …
Apr 8, 2024
6ab95f3
[AL2023]Add support for Amazon Linux 2023 - Mysql Client ( used Rhel9)
Apr 8, 2024
f8cd9ad
[AL2023]Add support for Amazon Linux 2023 - Munge
Apr 8, 2024
2ef8cc2
[AL2023]Add support for Amazon Linux 2023 - Slurm
Apr 8, 2024
4686d14
[AL2023]Add support for Amazon Linux 2023 - CloudWatchAgent
Apr 8, 2024
0517b0d
[AL2023]Add Comment for installing full featured packages
Apr 8, 2024
be7ce03
[AL2]removing duplicate functions in AL2022
Apr 9, 2024
7ab5ed8
[AL2023]CookStyle change
Apr 9, 2024
e62711e
[AL2023] Adding Github Actions for running Kitchen tests for Al2023
Apr 9, 2024
ee0f2b2
[AL2023] Unit tests for Nvidia Driver
Apr 9, 2024
f25ad05
[AL2023] Installing the full versions of packages as some of them con…
Apr 9, 2024
b346ad5
[AL2023] yum-utils is not supported in AL2023
Apr 9, 2024
8065007
[AL2023] Supporting AL2023 for Disable Sudo Access
Apr 16, 2024
6a6c076
[AL2023] Adding packages which are now supported with differnt names
Apr 19, 2024
3b21c22
[AL2023] Supporting Cluster User for Al2023
Apr 22, 2024
419a273
[AL2023]Adding Amazon in test metadata
Apr 24, 2024
10faecd
[AL2023] Install dmidecode
Apr 24, 2024
c424659
[AL2023]Update metadata for AL2023
Apr 24, 2024
960ff9f
[AL2023] Adding Guards for NVIDIA
Apr 24, 2024
51930ac
[AL2023] Support Cuda Installation by using root directory for instal…
Apr 24, 2024
6351b86
[AL2023] Adding installation of rsyslog and enabling the service
Apr 26, 2024
9136993
[AL2023] Supporting system authentication for AD
Apr 26, 2024
07a8dd2
[AL2023] Remove check to assert service running
Apr 26, 2024
d42a555
[AL2023] Avoid openssh recipe on Amazon Linux 2023 + docker
hanwen-cluster Jun 4, 2024
89d077c
[AL2023] mock directory when running tests on docker
hanwen-cluster Jun 5, 2024
b58c61a
[AL2023] remove prehook
hanwen-cluster Jun 5, 2024
33fd1d0
Remove support information in metadata
hanwen-cluster Jun 7, 2024
3f84028
[AL2023] Refactor rsyslog installation
hanwen-cluster Jun 11, 2024
9286e4c
[AL2023] Remove network interfaces configuration
hanwen-cluster Jun 11, 2024
1357fd7
[AL2023] Remove outdated packages
hanwen-cluster Jun 11, 2024
5552b26
Merge branch 'develop' into al2023
hanwen-pcluste Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cookbooks/aws-parallelcluster-platform/recipes/install/cuda.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@
cwd '/tmp'
code <<-CUDA
set -e
./cuda.run --silent --toolkit --samples
mkdir /cuda-install
./cuda.run --silent --toolkit --samples --tmpdir=/cuda-install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cuda-install is meant to be a temporary directory, so we should create it under /tmp.
That said it's fine to use recursive deletion of that folder since it's a temp directory created by us and not meant ot be used by the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tmp on some OSes has size limit. That's why we had to change the directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please add a comment on top of it to explain why we are not using tmp dir.
However, we should be in control of the tmp dir size and adjust it to our needs.
May you please track in the backlog the possibility to control the /tmp size as a separate partition (that is also a storage best practice)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added a comment

rm -rf /cuda-install
rm -f /tmp/cuda.run
CUDA
creates "/usr/local/cuda-#{cuda_version}"
Expand Down
4 changes: 3 additions & 1 deletion cookbooks/aws-parallelcluster-platform/spec/unit/recipes/cuda_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@
group: 'root',
cwd: '/tmp',
creates: "/usr/local/cuda-#{cuda_version}")
.with_code(%r{./cuda.run --silent --toolkit --samples})
.with_code(%r{mkdir /cuda-install})
.with_code(%r{./cuda.run --silent --toolkit --samples --tmpdir=/cuda-install})
.with_code(%r{rm -rf /cuda-install})
.with_code(%r{rm -f /tmp/cuda.run})
end

Expand Down