[develop]Simplify conditional statements in slurm conf template #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2682 +/- ##
========================================
Coverage 76.48% 76.48%
========================================
Files 22 22
Lines 2220 2220
========================================
Hits 1698 1698
Misses 522 522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
judysng
previously approved these changes
Mar 6, 2024
`Uri` is required by `Database` section. `Host` is required by `ExternalSlurmdbd`. Therefore, to check the existence of `Uri` or `Host`, we just need to check the existence of `Database` or `ExternalSlurmdbd`. This improvement simplifies the code and reduces the burden of mocking in testing. Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uriis required byDatabasesection.Hostis required byExternalSlurmdbd. Therefore, to check the existence ofUriorHost, we just need to check the existence ofDatabaseorExternalSlurmdbd.This improvement simplifies the code and reduces the burden of mocking in testing.
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.