Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -m=kernel-open flag optional to allow for ClosedRM drivers to be used #2615

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Jan 12, 2024

Description of changes

  • Make -m=kernel-open flag optional to allow for ClosedRM drivers to be used
  • This allows for user to make a custom AMI with ClosedRM drivers in order to be able to use instances types like p3.2xlarge that are not supported by OpenRM

Tests

I created two custom AMIs, one using ClosedRM withExtraChefAttributes: {"cluster": {"nvidia": {"enabled": "yes", "kernel-open": "false"}}} in the config file, and one using OpenRm with ExtraChefAttributes: {"cluster": {"nvidia": {"enabled": "yes"}}}

When I launched a p3.2xlarge using my custom AMIs I got the following results:
ClosedRm:

[ec2-user@ip-172-31-75-50 ~]$ nvidia-smi
Fri Jan 12 17:13:15 2024       
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.129.03             Driver Version: 535.129.03   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  Tesla V100-SXM2-16GB           Off | 00000000:00:1E.0 Off |                    0 |
| N/A   42C    P0              26W / 300W |      0MiB / 16384MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
                                                                                         
+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|  No running processes found                                                           |
+---------------------------------------------------------------------------------------+
[ec2-user@ip-172-31-75-50 ~]$ modinfo -F license nvidia
NVIDIA

OpemRM:

[ec2-user@ip-172-31-77-12 ~]$ nvidia-smi
NVIDIA-SMI has failed because it couldn't communicate with the NVIDIA driver. Make sure that the latest NVIDIA driver is installed and running.

[ec2-user@ip-172-31-77-12 ~]$ modinfo -F license nvidia
Dual MIT/GPL

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (517e55d) 75.56% compared to head (a6e1314) 75.56%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2615   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files           16       16           
  Lines         2132     2132           
========================================
  Hits          1611     1611           
  Misses         521      521           
Flag Coverage Δ
unittests 75.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hgreebe hgreebe force-pushed the develop branch 10 times, most recently from fc9fe06 to 5290e09 Compare January 17, 2024 01:10
enrico-usai
enrico-usai previously approved these changes Jan 17, 2024
@enrico-usai enrico-usai dismissed their stale review January 17, 2024 14:28

Missing changelog

CHANGELOG.md Outdated Show resolved Hide resolved
enrico-usai
enrico-usai previously approved these changes Jan 17, 2024
@@ -13,6 +13,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
- Intel Python: 2023.2.0
- Critical Update for Intel oneAPI DPC++/C++ Compiler: 2023.2.1
- Critical Update for Intel Fortran Compiler & Intel Fortran Compiler Classic: 2023.2.1
- Add possibility to choose between Open and Closed Source Nvidia Drivers when building an AMI, through the ```['cluster']['nvidia']['kernel_open']``` cookbook node attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One backtick is enough.

Copy link
Contributor

@hanwen-pcluste hanwen-pcluste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared Enrico's last approval with the latest code, and found no changes.
https://github.com/aws/aws-parallelcluster-cookbook/compare/ac2b4cd..882b93c930775b180bd1465e5fd012621ffcfcd3
Therefore, I am going to approve it again.

@hgreebe hgreebe enabled auto-merge (squash) January 17, 2024 17:20
@hgreebe hgreebe merged commit c5e1d83 into aws:develop Jan 17, 2024
28 checks passed
hgreebe added a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2024
… used (aws#2615)

* Make -m=kernel-open flag optional to allow for CloseRM drivers to be used

* Add ChefSpec for nvidia_kernel_module and modify CHANGELOG

Signed-off-by: Helena Greebe <[email protected]>
hgreebe added a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2024
… used (aws#2615)

* Make -m=kernel-open flag optional to allow for CloseRM drivers to be used

* Add ChefSpec for nvidia_kernel_module and modify CHANGELOG

Signed-off-by: Helena Greebe <[email protected]>
hgreebe added a commit that referenced this pull request Jan 18, 2024
… used (#2615) (#2619)

* Make -m=kernel-open flag optional to allow for CloseRM drivers to be used

* Add ChefSpec for nvidia_kernel_module and modify CHANGELOG

Signed-off-by: Helena Greebe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants