-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make -m=kernel-open flag optional to allow for ClosedRM drivers to be used #2615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2615 +/- ##
========================================
Coverage 75.56% 75.56%
========================================
Files 16 16
Lines 2132 2132
========================================
Hits 1611 1611
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cookbooks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
Outdated
Show resolved
Hide resolved
fc9fe06
to
5290e09
Compare
cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
Outdated
Show resolved
Hide resolved
@@ -13,6 +13,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste | |||
- Intel Python: 2023.2.0 | |||
- Critical Update for Intel oneAPI DPC++/C++ Compiler: 2023.2.1 | |||
- Critical Update for Intel Fortran Compiler & Intel Fortran Compiler Classic: 2023.2.1 | |||
- Add possibility to choose between Open and Closed Source Nvidia Drivers when building an AMI, through the ```['cluster']['nvidia']['kernel_open']``` cookbook node attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One backtick is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared Enrico's last approval with the latest code, and found no changes.
https://github.com/aws/aws-parallelcluster-cookbook/compare/ac2b4cd..882b93c930775b180bd1465e5fd012621ffcfcd3
Therefore, I am going to approve it again.
… used (aws#2615) * Make -m=kernel-open flag optional to allow for CloseRM drivers to be used * Add ChefSpec for nvidia_kernel_module and modify CHANGELOG Signed-off-by: Helena Greebe <[email protected]>
… used (aws#2615) * Make -m=kernel-open flag optional to allow for CloseRM drivers to be used * Add ChefSpec for nvidia_kernel_module and modify CHANGELOG Signed-off-by: Helena Greebe <[email protected]>
… used (#2615) (#2619) * Make -m=kernel-open flag optional to allow for CloseRM drivers to be used * Add ChefSpec for nvidia_kernel_module and modify CHANGELOG Signed-off-by: Helena Greebe <[email protected]>
Description of changes
Tests
I created two custom AMIs, one using ClosedRM with
ExtraChefAttributes: {"cluster": {"nvidia": {"enabled": "yes", "kernel-open": "false"}}}
in the config file, and one using OpenRm withExtraChefAttributes: {"cluster": {"nvidia": {"enabled": "yes"}}}
When I launched a p3.2xlarge using my custom AMIs I got the following results:
ClosedRm:
OpemRM:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.