Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.8] Increase retries when no dynamoDB entry is found #2528

Merged

Conversation

lukeseawalker
Copy link
Contributor

Description of changes

  • Increase retries when no dynamoDB entry is found, from 2 to 5 minutes

Tests

n/a

References

n/a

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Increase retries when no dynamoDB entry is found, from 2 to 5 minutes

Signed-off-by: Luca Carrogu <[email protected]>
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (127d43f) 76.06% compared to head (2d83d5e) 76.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.8    #2528   +/-   ##
============================================
  Coverage        76.06%   76.06%           
============================================
  Files               13       13           
  Lines             1876     1876           
============================================
  Hits              1427     1427           
  Misses             449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeseawalker lukeseawalker enabled auto-merge (rebase) November 8, 2023 15:09
auto-merge was automatically disabled November 9, 2023 08:26

Pull request was closed

@lukeseawalker lukeseawalker reopened this Nov 9, 2023
@lukeseawalker lukeseawalker enabled auto-merge (rebase) November 9, 2023 08:27
@lukeseawalker lukeseawalker merged commit cc559fc into aws:release-3.8 Nov 9, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants