[develop] Modify the check_login_stopped.sh script to directly use TG name to query #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2524 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…uery. Based on the lastest change in cli
hehe7318
force-pushed
the
wip/munge-key-reduce-check-ln-stop-steps
branch
from
b6fc2c9 to
daa8e2d
Compare
EddyMM
reviewed
Nov 1, 2023
| @@ -137,3 +140,11 @@ def get_primary_ip | |||
|
|
|||
| primary_ip | |||
| end | |||
|
|
|||
| def get_target_group_name(cluster_name, pool_name) | |||
There was a problem hiding this comment.
Let's add a ChefSpec test for this function.
EddyMM
reviewed
Nov 2, 2023
| @@ -0,0 +1,22 @@ | |||
| require_relative '../../../libraries/helpers' | |||
There was a problem hiding this comment.
Yes. The get_target_group_name function is in helpers.rb
EddyMM
approved these changes
Nov 2, 2023
hehe7318
added a commit
to hehe7318/aws-parallelcluster-cookbook
that referenced
this pull request
Nov 2, 2023
…uery (aws#2524) Reduce the check steps when checking if LoginNodes stopped. So that we can delete the checking NLB loop to reduce running time.
hgreebe
pushed a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Nov 13, 2023
…uery (aws#2524) Reduce the check steps when checking if LoginNodes stopped. So that we can delete the checking NLB loop to reduce running time.
himani2411
pushed a commit
to himani2411/aws-parallelcluster-cookbook
that referenced
this pull request
Nov 13, 2023
…uery (aws#2524) Reduce the check steps when checking if LoginNodes stopped. So that we can delete the checking NLB loop to reduce running time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.