[develop][fix] Add mock munge key logic in compute setup recipe during kitchen tests #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeamicis
requested changes
Oct 9, 2023
| @@ -6,6 +6,7 @@ | |||
| end | |||
|
|
|||
| file "#{munge_dir}/.munge.key" do | |||
| mode '0600' | |||
| content 'munge-key' | |||
There was a problem hiding this comment.
munge-key is not a good content for a munge key :D
The content must be binary, and at least 32 bytes long. Please find a way to pass a binary blob to this file.
There was a problem hiding this comment.
Done! I use the same logic as the rotation script does(which means the config and update process do).
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2487 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hehe7318
force-pushed
the
wip/munge-key-fix-compute
branch
from
938df41 to
aa836ef
Compare
jdeamicis
approved these changes
Oct 10, 2023
hehe7318
force-pushed
the
wip/munge-key-fix-compute
branch
2 times, most recently
from
33c312a to
474f86d
Compare
hehe7318
force-pushed
the
wip/munge-key-fix-compute
branch
from
474f86d to
cc0bcf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).