Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop][fix] Add only if condition in the slurm munge key kitchen tests #2479

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Oct 3, 2023

Description of changes

  • Fix the kitchen tests failed in AWS Batch

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

@hehe7318 hehe7318 requested review from a team as code owners October 3, 2023 17:31
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9e408e0) 76.06% compared to head (0b3f16f) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2479   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hehe7318 hehe7318 force-pushed the wip/munge-key-fix-tests branch from b5fd54c to 0b3f16f Compare October 5, 2023 01:33
@hehe7318 hehe7318 merged commit 3e9f10d into aws:develop Oct 5, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants