Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify permissions of /etc/sysconfig directory #2477

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

judouk
Copy link
Contributor

@judouk judouk commented Oct 2, 2023

Directory permissions set to 0644 incorrectly leading to permissions problems when a non-root user tries to read files from /etc/sysconfig

Description of changes

  • Changed default permissions of a directory. Suspect that this was originally done inadvertently as a directory should not have perms of 0644

Tests

  • n/a

References

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Directory permissions set to 0644 incorrectly leading to permissions problems when a non-root user tries to read files from /etc/sysconfig
@judouk judouk requested review from a team as code owners October 2, 2023 14:17
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (74c71d6) 76.06% compared to head (4581d6b) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2477   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai changed the title Update finalize_compute.rb Modify permissions of /etc/sysconfig directory Oct 2, 2023
Copy link
Contributor

@enrico-usai enrico-usai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @judouk for fixing this!

@enrico-usai enrico-usai enabled auto-merge (rebase) October 2, 2023 14:51
@enrico-usai enrico-usai merged commit 4c7d871 into aws:develop Oct 2, 2023
@judouk judouk deleted the patch-1 branch October 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants