-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EFA to 1.26.1 #2476
Upgrade EFA to 1.26.1 #2476
Conversation
The hash of the installer can be retrieved here https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-verify.html Signed-off-by: Hanwen <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2476 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
- apt-7.5.14 (from apt-7.4.0) | ||
- line-4.5.13 (from line-4.5.2) | ||
- openssh-2.11.3 (from openssh-2.10.3) | ||
- pyenv-4.2.3 (from pyenv-3.5.1) | ||
- selinux-6.1.12 (from selinux-6.0.5) | ||
- yum-7.4.13 (from yum-7.4.0) | ||
- yum-epel-5.0.2 (from yum-epel-4.5.0) | ||
- apt-7.5.14 (from apt-7.4.0) | ||
- line-4.5.13 (from line-4.5.2) | ||
- openssh-2.11.3 (from openssh-2.10.3) | ||
- pyenv-4.2.3 (from pyenv-3.5.1) | ||
- selinux-6.1.12 (from selinux-6.0.5) | ||
- yum-7.4.13 (from yum-7.4.0) | ||
- yum-epel-5.0.2 (from yum-epel-4.5.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you have the check yaml pre-commit hook enabled. Could you revert this change in this block please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change it
CHANGELOG.md
Outdated
@@ -362,7 +361,6 @@ This file is used to list changes made in each version of the AWS ParallelCluste | |||
**ENHANCEMENTS** | |||
- Add support for multiple users cluster environments by integrating with Active Directory (AD) domains managed via AWS Directory Service. | |||
- Install NVIDIA drivers and CUDA library for ARM. | |||
- Build Slurm with `slurmrestd` support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its weird that changelog is not consistent throughout the branches.
This line was not in release-3.7 changelog and neither in release-3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this line please. We may consider fixing the 3.7 branch later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the change in develop changelog was added in this #2446.
but not picked for release-3.7 branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I guess they didn't want to modify all the release branches.
The hash of the installer can be retrieved here https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-verify.html Signed-off-by: Hanwen <[email protected]> Co-authored-by: Hanwen <[email protected]>
The hash of the installer can be retrieved here https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-verify.html
Picked the Commit from Release-3.7 #2460
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.