[develop] Reuse the rotation script inside the munge resource

[hehe7318]

Description of changes

• Avoid code duplication by reusing the "rotation" script inside the munge resource when retrieving the custom munge key from Secrets Manager

Checklist

• Make sure you are pointing to the right branch.
• If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
• Check all commits' messages are clear, describing what and why vs how.
• Make sure to have added unit tests or integration tests to cover the new/modified code.
• Check if documentation is impacted by this change.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f905257) 76.06% compared to head (90f7216) 76.06%.
Report is 1 commits behind head on develop.

❗ Current head 90f7216 differs from pull request most recent head 6d6a6a4. Consider uploading reports for the commit 6d6a6a4 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2471   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           

Flag	Coverage Δ
unittests	76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jdeamicis]

Good job. Just implement the change I requested and then we can merge it.

[jdeamicis]

This is not what we had discussed yesterday. Please address the comments.

[jdeamicis]

You have to rebase your PR on top of other developments, so I will just provide a comment here.

[jdeamicis]

I believe you can simplify this block:

def fetch_and_decode_munge_key
  declare_resource(:execute, 'fetch_and_decode_munge_key') do
    user 'root'
    group 'root'
    command "/#{node['cluster']['scripts_dir']}/slurm/update_munge_key.sh -d"
  end
end

[hehe7318]

Great comment! Thank you Jacopo.

[jdeamicis]

I wonder if we actually need the first / character in the command variable. Though, in principle scripts_dir will always be an absolute path, so it shouldn't hurt.

[jdeamicis]

I wonder if we actually need the first / character in the command variable. Though, in principle scripts_dir will always be an absolute path, so it shouldn't hurt.