-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CodeQL #2449
Fixes for CodeQL #2449
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2449 +/- ##
===========================================
- Coverage 70.53% 70.49% -0.04%
===========================================
Files 13 13
Lines 1863 1864 +1
===========================================
Hits 1314 1314
- Misses 549 550 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
8497102
to
6e37684
Compare
Could you add more descriptive commit messages. |
Also, Can you have a look at which unit tests might be covering the tests as there are codecov checks which mention that the coverage is reduced. |
…mment in cloudwatch_agent_config_util.py Signed-off-by: Judy Ng <[email protected]>
6e37684
to
3f789db
Compare
…mment in cloudwatch_agent_config_util.py (aws#2449) Signed-off-by: Judy Ng <[email protected]>
…mment in cloudwatch_agent_config_util.py (aws#2449) Signed-off-by: Judy Ng <[email protected]>
Description of changes
CodeQL findings:
Going to Security > Code Scanning and typing "pr:2449" shows that the CodeQL alerts don't show up anymore!
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.