Add unit tests for cookbook EBS related scripts

[judysng]

Description of changes

• Wrote unit tests for functions ec2_dev_2_volid and manageVolume because these files lacked unit tests
• Separated the main function in ec2_dev_2_volid into multiple functions
• Fixed typo in manageVolume

Tests

• Added tests for most functions in the two files except for some functions that just called the other tested functions

Checklist

• Make sure you are pointing to the right branch.
• If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
• Check all commits' messages are clear, describing what and why vs how.
• Make sure to have added unit tests or integration tests to cover the new/modified code.
• Check if documentation is impacted by this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[himani2411]

Are we not testing this function?

[judysng]

I decided not to test this function because it seemed to just be calling lots of other functions without much logic in that function itself. Let me know if you think I should test this too though!

[codecov]

Codecov Report

Patch coverage: 34.28% and project coverage change: +5.51% 🎉

Comparison is base (71c252b) 70.49% compared to head (607f7d6) 76.01%.

❗ Current head 607f7d6 differs from pull request most recent head 721e484. Consider uploading reports for the commit 721e484 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2445      +/-   ##
===========================================
+ Coverage    70.49%   76.01%   +5.51%     
===========================================
  Files           13       13              
  Lines         1864     1876      +12     
===========================================
+ Hits          1314     1426     +112     
+ Misses         550      450     -100     

Flag	Coverage Δ
unittests	76.01% <34.28%> (+5.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...nt/files/default/ec2_udev_rules/ec2_dev_2_volid.py	64.00% <28.00%> (+34.76%)	⬆️
...nment/files/default/ec2_udev_rules/manageVolume.py	79.85% <50.00%> (+59.41%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[enrico-usai]

In general it's useful to split this kind of changes in multiple small commits, e.g.:

• create parse_proxy_config function
• create get_device_volume_id
• fix typo in manageVolume function
• add unit tests for xxx function

This simplifies the review.

Instead you should fixup the second commit you created, this doesn't have any meaning by itself, it's a fix of the previous commit so they should be merged together. See https://www.jetbrains.com/idea/guide/tips/interactive-rebase/

Anyway you did a great job, you can see here how your patch is increasing the coverage of about 6%.