Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the failing features for the Ubuntu 22 AMI build in kitchen tests and skip the exit status for cloudwatch on Ubuntu 22 #2338

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

dreambeyondorange
Copy link
Contributor

Tests

  • Built AMI in personal jenkins

References

  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange requested review from a team as code owners June 28, 2023 20:00
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2338 (eba02ce) into develop (f9e4f52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2338   +/-   ##
========================================
  Coverage    70.16%   70.16%           
========================================
  Files           13       13           
  Lines         1840     1840           
========================================
  Hits          1291     1291           
  Misses         549      549           
Flag Coverage Δ
unittests 70.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

himani2411
himani2411 previously approved these changes Jun 28, 2023
…s as well

Skip exit status for cloudwatch on Ubuntu 22
@dreambeyondorange dreambeyondorange merged commit b27ac94 into aws:develop Jun 28, 2023
rkilpadi pushed a commit that referenced this pull request Jul 21, 2023
…s as well (#2338)

Skip exit status for cloudwatch on Ubuntu 22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants