[Bug] Adding different values for kernel-open option (#2733)

Co-authored-by: Himani Deshpande <[email protected]>
aws · May 23, 2024 · 136014b · 136014b
1 parent 26a3c9d
commit 136014b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...oks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb b/...oks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
@@ -113,7 +113,7 @@ def compiler_version
 end
 
 def nvidia_kernel_module
-  if node['cluster']['nvidia']['kernel_open'] == "false"
+  if ['false', 'no', false].include?(node['cluster']['nvidia']['kernel_open'])
     "kernel"
   else
     "kernel-open"

diff --git a/cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb b/cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
@@ -96,7 +96,7 @@ def self.setup(chef_run, nvidia_driver_version: nil)
 end
 
 describe 'nvidia_driver:nvidia_kernel_module' do
-  [%w(false kernel), %w(true kernel-open)].each do |kernel_open, kernel_module|
+  [%w(false kernel), [false, 'kernel'], %w(no kernel), %w(true kernel-open), [true, 'kernel-open'], %w(yes kernel-open)].each do |kernel_open, kernel_module|
     context "node['cluster']['nvidia']['kernel_open'] is #{kernel_open}" do
       cached(:chef_run) do
         ChefSpec::SoloRunner.new(step_into: ['nvidia_driver']) do |node|