generate resource files for k8s 1.25 #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdk27
suggested changes
Apr 12, 2023
pdk27
approved these changes
Apr 12, 2023
| mkdir -p $QP_INDV_RESOURCES_DIR | ||
|
|
||
| HELM=$BUILD_DIR/helm | ||
| if [[ ! -e $HELM ]]; then |
There was a problem hiding this comment.
what's the purpose of this check?
There was a problem hiding this comment.
The script downloads its own copy of the helm executable if doesn't already exist in the build directory. Since we know the script will be run twice this check prevents an unnecessary re-download.
|
will additional changes be required to support 1.26? |
Hi @bryantbiggs, we expect the 1.25 resource files will be compatible with 1.26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#799 v1.25+ Compatible Release Resource Artifacts
Description of changes:
Updated script to generate two sets of resources for k8s 1.24 and 1.25
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.