Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated config checkASGTagBeforeDraining in end-to-end tests #753

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

snay2
Copy link
Contributor

@snay2 snay2 commented Dec 22, 2022

Issue #, if available: N/A

Description of changes:

Replace checkASGTagBeforeDraining with checkTagBeforeDraining in end-to-end tests

Some end-to-end tests were getting the following warning in their logs (see this example):

2022/12/22 22:25:24 WRN Deprecated argument "check-asg-tag-before-draining" and the replacement argument "check-tag-before-draining" was provided. Using the newer argument "check-tag-before-draining"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Replace with the new name: `checkTagBeforeDraining`
@snay2 snay2 marked this pull request as ready for review December 22, 2022 23:08
@snay2 snay2 requested a review from a team as a code owner December 22, 2022 23:08
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jan 7, 2023
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues / PRs with no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants