Remove unnecessary configuration in Queue Processor mode #745
Conversation
rocessor mode
johngmyers
force-pushed
the
prune-config
branch
from
9f2b20b to
11702e2
Compare
| @@ -150,12 +150,12 @@ The configuration in this table applies to AWS Node Termination Handler in IMDS | |||
| | `daemonsetTolerations` | Tolerations for DaemonSet pod assignment. For backwards compatibility the `tolerations` has priority over this but shouldn't be used. | `[]` | | |||
| | `linuxTolerations` | Override `daemonsetTolerations` for the Linux DaemonSet. | `[]` | | |||
| | `windowsTolerations` | Override `daemonsetTolerations` for the Linux DaemonSet. | `[]` | | |||
| | `enableProbesServer` | If `true`, start an http server exposing `/healthz` endpoint for probes. | `false` | | |||
| | `enableProbesServer` | If `true`, start an http server exposing `/healthz` endpoint for probes. Only used in IMDS mode. | `false` | | |||
There was a problem hiding this comment.
This is incorrect. The probes server can be exposed whether NTH runs as a daemonset or as a deployment and is not related to IMDS mode. Our default configurations here only enable it for the daemonset, not the deployment, but that is not a technical limitation.
Indeed, our release artifacts explicitly include an aggregated YAML configuration with probes server enabled in Queue Processor mode as a deployment (see the artifact all-resources-queue-processor.yaml from any v1 release). Here's the code that generates that file:
aws-node-termination-handler/scripts/generate-k8s-yaml
Lines 61 to 66 in c3e411b
| @@ -259,22 +259,22 @@ daemonsetTolerations: | |||
| linuxTolerations: [] | |||
| windowsTolerations: [] | |||
|
|
|||
| # If the probes server is running for the Daemonset | |||
| # If the probes server is running for the Daemonset. Only used in IMDS mode. | |||
There was a problem hiding this comment.
To be more correct, let's remove "for the Daemonset", since the probes server can be used in a deployment and is not related to IMDS mode.
| # If the probes server is running for the Daemonset. Only used in IMDS mode. | |
| # If the probes server is running |
johngmyers
force-pushed
the
prune-config
branch
from
1e1911a to
2071522
Compare
Issue #, if available:
None
Description of changes:
Remove configuration settings that don't affect Queue Processor mode (assuming #743 merges) from the Deployment template, so that they don't act as red herrings.
Document the settings that only apply to IMDS mode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.